SunVox - Inconsistent module names, change affects library [not a bug]

Found a bug? Post it here.
Post Reply
User avatar
Sotakebk
Posts: 16
Joined: Thu Nov 03, 2022 8:52 pm

SunVox - Inconsistent module names, change affects library [not a bug]

Post by Sotakebk »

Names are inconsistent.
Some are “PascalCase”:
  • DrumSynth,
  • SpectraVoice,
  • WaveShaper,
  • MetaModule,
  • MultiSynth,
(all the one word ones, too);
some have spaces with “Inconsistent capitalization”:
  • Filter Pro,
  • Pitch shifter,
  • Vocal filter,
  • Vorbis player
While it's only cosmetic, if you're going to ever change it, it will impact any derivative software, since you can get the type name of a module and use it for your logic or whatever. I believe a “now or never” approach applies here.
image_2023-02-03_123823033.png
image_2023-02-03_123823033.png (9.56 KiB) Viewed 3184 times
Last edited by Sotakebk on Sun Feb 05, 2023 2:36 am, edited 1 time in total.
User avatar
NightRadio
Site Admin
Posts: 3941
Joined: Fri Jan 23, 2004 12:28 am
Location: Ekaterinburg. Russia
Contact:

Re: SunVox - Inconsistent module names, change affects library

Post by NightRadio »

While it's only cosmetic, if you're going to ever change it
That's right. Maybe this is not the best architectural solution. But I don't see any problem here, and I certainly don't see a bug.
Of course, I can never change it :)
User avatar
Sotakebk
Posts: 16
Joined: Thu Nov 03, 2022 8:52 pm

Re: SunVox - Inconsistent module names, change affects library

Post by Sotakebk »

Eh, I'm used to having spelling mistakes reported as high priority bugs :P I guess it is more of a suggestion
Ol sen
Posts: 20
Joined: Sat Feb 12, 2022 6:26 am

Re: SunVox - Inconsistent module names, change affects library [not a bug]

Post by Ol sen »

An extended psynth_command enum in psynth.h

Code: Select all

enum psynth_command
{
    PS_CMD_NOP = 0,
    ...
    ...
    ...
    //suggestion
    PS_CMD_GET_TYPE_AS_INDEX, //module type as index, that way i can ask the module of its type directly without string comparison.
    PS_CMD_PUBLISH_CONTROL, //event to publish parameter on parent pnet
    PS_CMD_UNPUBLISH_CONTROL, //event to unpublish parameter from parent pnet
    
    PSYNTH_COMMANDS
};
Post Reply